Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not adhere to targets.js #30

Closed
boris-petrov opened this issue Nov 26, 2019 · 2 comments · Fixed by #33
Closed

Does not adhere to targets.js #30

boris-petrov opened this issue Nov 26, 2019 · 2 comments · Fixed by #33

Comments

@boris-petrov
Copy link
Contributor

Even with ie11 in targets.js, ES6+ code is being generated - the let keyword is being used and catch without parentheses for example.
@pzuraq
Copy link
Collaborator

pzuraq commented Nov 26, 2019

The code for this addon doesn't get transpiled, and it looks like a few usages of modern features slipped through, my bad 😔

https://github.com/emberjs/ember-classic-decorator/blob/master/vendor/classic-decorator/index.js#L147

Will try to get a fix up soon

@boris-petrov
Copy link
Contributor Author

@pzuraq - thanks. This also seems to break Firefox 47.

@boris-petrov boris-petrov mentioned this issue Dec 17, 2019
Merged
@gil3r gil3r mentioned this issue Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove usages of ES6+ features
2 participants
@boris-petrov @pzuraq