Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector is not detecting Ember deprecations #833

Closed
urbany opened this issue Jul 23, 2018 · 2 comments
Closed

Inspector is not detecting Ember deprecations #833

urbany opened this issue Jul 23, 2018 · 2 comments
Labels

Comments

@urbany
Copy link

urbany commented Jul 23, 2018

Just tried in a fresh ember new with latest release versions of all packages and as you can see, in the screenshot below, the inspector is not picking up the deprecations.

screen shot 2018-07-20 at 15 52 25

@bgentry
Copy link
Contributor

bgentry commented Jul 25, 2018

@urbany those specific deprecations were caused by ember-inspector itself, not your app. Maybe that's why they weren't showing up?

Those specific deprecations should be resolved now that #835 is merged (pending an actual release, of course).

Edit: from your description it sounds like this was a brand new app, so there shouldn't be any deprecation warnings in the app itself. Maybe this can be closed then?

@urbany
Copy link
Author

urbany commented Jul 28, 2018

I think this should only be closed when a new version of ember-inspector is released with your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants