Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Inspect Ember Component Icon with Ember "e" #871

Closed
RobbieTheWagner opened this issue Sep 27, 2018 · 10 comments
Closed

Replace Inspect Ember Component Icon with Ember "e" #871

RobbieTheWagner opened this issue Sep 27, 2018 · 10 comments

Comments

@RobbieTheWagner
Copy link
Member

We currently use the Tomster logo, but it is small and hard to tell what it is. The "e" logo would also match favicons from other Ember sites.

@nummi
Copy link
Collaborator

nummi commented Sep 28, 2018

We have one in the project (public/images) but it is very low resolution. Maybe we could get a better one and use that? Vue seems to have a higher res' icon.

screen shot 2018-09-28 at 9 01 10 am

@RobbieTheWagner
Copy link
Member Author

@nummi yeah, I was also thinking we should do the "e" without the square background.

@dipil-saud
Copy link
Contributor

@rwwagner90 Having been using this extension for a long time now, It'd be great to contribute to it, so I'd like to take this up.
The ember brand guidelines has 3 types of icons defined for the minimal icons. Do we want to go with one of these or something modified?
image
Using the e without the square background is also a good idea but we'll need to make the e orange in that case.

@nummi
Copy link
Collaborator

nummi commented Oct 10, 2018

My vote is for the rounded square or circle. Could you try both and upload a couple screenshots?

@nummi
Copy link
Collaborator

nummi commented Oct 10, 2018

Also while we're tinkering with that icon maybe we could improve on the icon in the Firefox developer tab?

@RobbieTheWagner
Copy link
Member Author

@dipil-saud I agree with @nummi, I like the circle and rounded square. I would be fine with either.

@dipil-saud
Copy link
Contributor

Samples
ember-inspector

@RobbieTheWagner
Copy link
Member Author

@dipil-saud I think I like the circle. I feel like an "e" with no background could look good too, but as you mentioned, that is not in the recommended assets to use.

@locks any suggestions or preferences here?

@locks
Copy link
Contributor

locks commented Oct 11, 2018

I think I'm partial to the square out of familiarity, but as long as it is one of the options from the branding page, I am ok with it 😁

@RobbieTheWagner
Copy link
Member Author

@dipil-saud feel free to pick whichever you prefer and open a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants