Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing run loop at the beginning of test interferes with Ember.run.join behavior #160

Open
ming-codes opened this issue Aug 24, 2017 · 1 comment

Comments

@ming-codes
Copy link

ming-codes commented Aug 24, 2017

screen shot 2017-08-22 at 3 39 17 pm

I'm not sure if this is intentional, but the behavior is definitely different from what ember-qunit have. Unit tests should not have a run loop started already.

@ghost
Copy link

ghost commented Oct 30, 2017

I think this issue caused a test failure bug in our application test suite. A mixin's unit test had scheduled run loop actions using Ember run next. This mixin did not properly clean up those deferred actions. Later in the test suite we saw obscure run loop errors. I would expect ember-mocha to warn or error if things exist in the run loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants