Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types missing from version 3 #1397

Closed
boris-petrov opened this issue Jun 1, 2023 · 4 comments · Fixed by #1401
Closed

Types missing from version 3 #1397

boris-petrov opened this issue Jun 1, 2023 · 4 comments · Fixed by #1401

Comments

@boris-petrov
Copy link

There are no TypeScript types in the release.
@MelSumner
Copy link
Contributor

the types/ directory was excluded from the published package because the package builds types to public-types/ for publishing. Can you check there please?

@boris-petrov
Copy link
Author

There is no such directory in the package. :) And I get type errors with TypeScript.

@MelSumner
Copy link
Contributor

MelSumner commented Jun 1, 2023 •
edited
Loading

ok! That means that our idea was not correct; I'll reproduce the issue locally just to make sure, and get a new patch out shortly. Thanks for confirming!

@MelSumner MelSumner mentioned this issue Jun 1, 2023
Merged
@MelSumner MelSumner linked a pull request Jun 1, 2023 that will close this issue
fixing the release #1401
Merged
@MelSumner
Copy link
Contributor

Update: It seems like there are some undocumented pre-publish steps that would have included the public-types folder. Working on a new release now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing the release emberjs/ember-test-helpers
2 participants
@boris-petrov @MelSumner