Anomalies in current published version compared to previous versions

[MelSumner]

Screenshot:

On the left, the files in v2.9.3 in an app. On the right, the files in v3.0.2 in an app.

While the types/ directory is now excluded intentionally, I suspect that the changelog and licenses still need to be published. We also really should not have had to change public-types to dist-types in order for it to successfully publish from a functional perspective. So something really weird is going on, and it needs deeper investigation.

[MelSumner]

So in considering what's changed between the two versions, the file structure is the first thing that comes to mind.

I think we need to move the licenses inside of the addon folder.
But if this was the complete answer, I think we should have seen the CHANGELOG published. This would suggest that there's still something funky going on.

[fivetanley]

Adding to the list of anomalies: It seems that only typescript files are ending up in the tarball published to npm. https://www.npmjs.com/package/@ember/test-helpers?activeTab=code. For version 3.0.2:

This should be full of JS files but it's not. I think that's what's causing the build to fail for this PR (emberjs/ember-qunit#1077). The app tries to pull in the add-on, which works, but because there are no JS files, and there is no ember-cli-typescript configured, no modules for @ember/test-helpers get built/defined, leading to the "no module @ember/test-helpers" error.

[NullVoxPopuli]

what's goofy is that the prepack script includes build, which generates all the JS

But I confirmed that both npm pack and yarn pack, that all the JS files are excluded.

[NullVoxPopuli]

I have a fix! #1408

[MelSumner]

Re-opening because npm pack is still revealing that we're missing changelog and license files. I think I know how to fix this, PR incoming.