Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

willTransition() is called twice when using transition.abort() #14931

Closed
jdhines opened this issue Feb 15, 2017 · 2 comments
Closed

willTransition() is called twice when using transition.abort() #14931

jdhines opened this issue Feb 15, 2017 · 2 comments

Comments

@jdhines
Copy link

jdhines commented Feb 15, 2017

Using Ember 1.13
I can't tell if this is only happening when serving locally because I don't want to push a broken app to prod, but I'm currently experiencing an issue while trying to abort a transition if the record is dirty and the user cancels the JS confirm box.

Slimming down the hook to just this dumps out the log message twice:

willTransition: function(transition) {
  console.log('transition aborted'); //gets printed twice
  transition.abort();
}

If it matters, the current route looks like this: project/:project_id/sub-route/sub-sub-route

I have tried to reproduce with a Twiddle as well as newing up a fresh 1.13 Ember app, but it's behaving correctly in both places.

p.s. I've tried both Slack and Stack Overflow already, but didn't get any responses, so wondering if this is a bug. Need to get this fixed, but I'm at a loss of what else to look for!

@Serabe
Copy link
Member

Serabe commented Mar 2, 2017

Ember 1.13 is no longer maintained and it is unlikely that a bug gets fixed since the code has evolved a lot in 18 months.

Closing this, sorry.

@Serabe Serabe closed this as completed Mar 2, 2017
@joehany
Copy link

joehany commented May 16, 2018

happens with Ember 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants