Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] RouterService.transitionTo() API docs refer to API docs of deprecated Route.transitionTo() method #19896

Closed
jelhan opened this issue Jan 12, 2022 · 5 comments

Comments

@jelhan
Copy link
Contributor

jelhan commented Jan 12, 2022

📙 Describe the Issue

The API docs for transitionTo method of RouterService refer the reader to API docs of transitionTo method of Route, which is deprecated "for more info".

The embedded link is also broken and does not open the API docs of the deprecated method directly because deprecated methods are not shown by default

🔬 Minimal Reproduction

Source code:

See [transitionTo](/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo) for more info.

API docs for Ember 4.1 (latest release by time of reporting this): https://api.emberjs.com/ember/release/classes/Route/methods/transitionTo?anchor=transitionTo&show=inherited%2Cdeprecated

😕 Actual Behavior

API docs point user to deprecated method for more information.

🤔 Expected Behavior

Information, which are present on API docs for Route.transitionTo() should be copied over to RouterService.transitionTo().

➕ Additional Context

Route.transitionTo was deprecated by RFC 674.

@Satyap1766
Copy link

Hi, is anyone working in this ?

@locks
Copy link
Contributor

locks commented Feb 13, 2022

Hi, I assigned @Alzamer as they asked before.

@Alzamer Alzamer removed their assignment Mar 16, 2022
@gustavonikov
Copy link

Is someone taking this issue?

@kirtan-desai
Copy link
Contributor

Looks like this issue is resolved @jelhan

@jelhan
Copy link
Contributor Author

jelhan commented Jun 19, 2022

Thanks a lot for the heads up. Checked for RouterService.transitionTo and RouterService.replaceWith. Both are fixed. Thanks a lot to whoever took care of it!

@jelhan jelhan closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants