Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests hang on silent app errors #3

Closed
zeppelin opened this issue Aug 23, 2018 · 5 comments
Closed

Tests hang on silent app errors #3

zeppelin opened this issue Aug 23, 2018 · 5 comments
Labels

Comments

@zeppelin
Copy link

When fastboot.visit() fails, the response never gets sent or logged to the console, making the tests hang.

It would be cool if the error was both logged AND sent inside the response body.

@ryanto
Copy link
Member

ryanto commented Aug 31, 2018

Thanks for the report!

Could you give me an example of a silent error? Would love to get a test case coded for this.

@ryanto
Copy link
Member

ryanto commented Sep 19, 2018

Hey @zeppelin - Just wanted to follow up and see if you could point me at an example of this happening. Thanks!

@zeppelin
Copy link
Author

I'm gonna try to add the addon to the app once again, after I finish the current milestone!

@zeppelin
Copy link
Author

So one example is when the request fails with

Error: The host header did not match a hostWhitelist entry. Host header: ember-cli-fastboot-testing.localhost

This error never makes to the console.

@ryanto
Copy link
Member

ryanto commented Apr 25, 2019

Awesome and thanks. This is all fixed now and the error message will be rendered inside of the testing container.

It's released as 0.0.12

@ryanto ryanto closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants