Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config not working #488

Closed
hoIIer opened this issue Aug 19, 2021 · 5 comments · Fixed by #762
Closed

Config not working #488

hoIIer opened this issue Aug 19, 2021 · 5 comments · Fixed by #762
Labels

Comments

@hoIIer
Copy link

hoIIer commented Aug 19, 2021

I'm running into an issue where defining config/fastboot-testing.js isn't working as expected.

I was able to determine that the addon code indeed finds the config and exports it to be initialized with Fastboot(), however when the tests actually run, the global URL is not set properly and so my test fails.

I'm not sure why the global would not be available when the test runs or how to debug this?

For more info see my comment here:
ember-fastboot/ember-cli-fastboot#816 (comment)

edit 1

I determined the reason this fails is due to the version of fastboot in this addon.

It seems that buildSandboxGlobals() isn't working in 2.X but is working in latest 3.2.0-beta.2

Not sure how to proceed other than disabling my fastboot tests until either 3.0 comes out and/or the URL issue is resolved, but open to ideas!

@SergeAstapov
Copy link
Collaborator

@erichonkanen could you please confirm which version of this library you are using?

v0.5.0 and v0.4.0 of ember-cli-fastboot-testing use fastboot@3 as can be seen here https://github.com/embermap/ember-cli-fastboot-testing/blob/v0.5.0/package.json#L28

@runspired
Copy link

I think this may actually be the issue with buildSandboxGlobals I reported in ember-fastboot/ember-cli-fastboot#913

When digging in, it seems for ember-cli-fastboot@4.x config/fastboot.js works as expected, but for ember-cli-fastboot-testing@0.6 neither config/fastboot-testing.js nor config/fastboot.js works :/

@runspired
Copy link

Ah.... the config/fastboot-testing.js is not a function like config/fastboot.js is. Needs to be an exported object

@SergeAstapov
Copy link
Collaborator

@runspired ah yes, seems redundant and better change it to match format ember-cli-fastboot uses.
we should do it in v0.7.0

@gilest
Copy link
Contributor

gilest commented Mar 19, 2023

@runspired ah yes, seems redundant and better change it to match format ember-cli-fastboot uses. we should do it in v0.7.0

Seems like this has tripped up a number of users. PR in #762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants