Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Immediate flag should be really immediate #30

Closed
rajatbarman opened this issue Jun 29, 2019 · 1 comment
Closed

Immediate flag should be really immediate #30

rajatbarman opened this issue Jun 29, 2019 · 1 comment
Assignees
@embiem
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@rajatbarman
Copy link

Right now it is in a setTimeout with 0 timeout, this affects drawing experience a bit. If immediate is true it should execute without setTimeout like implemented in this file.

https://github.com/rajatbarman/react-canvas-draw/blob/master/src/index.js
@embiem embiem added bug Something isn't working good first issue Good for newcomers labels Nov 22, 2019
@embiem embiem self-assigned this Dec 29, 2019
@embiem embiem mentioned this issue Dec 29, 2019
Merged
@embiem
Copy link
Owner

embiem commented Dec 29, 2019

Thanks for reporting!

This is now fixed in version 1.1.0

@embiem embiem closed this as completed Dec 29, 2019
@embiem embiem added bug Something isn't working good first issue Good for newcomers and removed bug Something isn't working good first issue Good for newcomers labels Dec 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@embiem embiem

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embiem @rajatbarman