Changes required for Windows ARM64 #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged this into our internal devel branch. Change will be in next release. |
This was referenced Nov 30, 2022
aaronfranke
reviewed
Apr 10, 2024
| @@ -89,7 +89,7 @@ namespace embree | |||
| #endif | |||
| } | |||
|
|
|||
| #if defined(__X86_64__) | |||
| #if defined(__X86_64__) || defined (__aarch64__) | |||
There was a problem hiding this comment.
__aarch64__ is not defined on a pure Arm64 Windows environment with Arm64 MSVC, so this change is not sufficient to make it compile. However, _M_ARM64 is defined.
Why is this function conditionally compiled for only x86_64 and arm64 anyway? Can we just replaced it with a uint64_t version and make it always compiled? Or can we make it compiled for any 64-bit platform?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few changes in order to make embree compile for arm64-windows target.
Note: clang-cl must be used for NEON