Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencySatisfies + macroCondition ignores ember-source >= 4.0.0Z #1057

Closed
NullVoxPopuli opened this issue Dec 17, 2021 · 4 comments
Closed

Comments

@NullVoxPopuli
Copy link
Collaborator

I found an incorrect modifier manager right now:
image

and without sourcemaps:
image

I'm using ember-source-4.2-alpha.4

@NullVoxPopuli
Copy link
Collaborator Author

I wonder if this is related to: #1038

which, I took a stab at fixing here: #1053

but I don't know what's supposed to happen.

@ef4
Copy link
Contributor

ef4 commented Dec 20, 2021

I think this was fixed in #1053.

@NullVoxPopuli
Copy link
Collaborator Author

I don't think this is resolved:
image

(unless #1053 isn't released?)

@NullVoxPopuli
Copy link
Collaborator Author

if ((0,_home_nullvoxpopuli_Development_NullVoxPopuli_limber_node_modules_embroider_macros_src_addon_runtime__WEBPACK_IMPORTED_MODULE_0__.macroCondition)(false)) {
  // new enough ember has a real module we can import
  runtime = __webpack_require__(/*! ../../../../externals/@glimmer/runtime */ "../../externals/@glimmer/runtime.js");
} else {
  // older ember has its own internal loader
  runtime = window.Ember.__loader.require('@glimmer/runtime');
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants