Route splitting on pods found under ./app/routes/

[evoactivity]

Repro repo: https://github.com/evoactivity/embroider-route-split-pods-routes-dir

When pods are found in the ./app/routes/ directory by setting podModulePrefix to my-app/routes and they are route split the routes do not load with no runtime or build errors.

[ef4]

I think all that is needed to fix this case is re-ordering the calls to the classic and pods implementations here:

embroider/packages/core/src/app-files.ts

Lines 111 to 112 in 9834d5b

	this.handleClassicRouteFile(relativePath) ||
	(podModulePrefix !== undefined && this.handlePodsRouteFile(relativePath, podModulePrefix))

Settings podsModulePrefix to my-app/routes means that your route files also match the classic route files handling, and since that gets tried first it doesn't ever try to do the pod-specific handling.

[evoactivity]

I tried a quick patch to app-files.js in my node_modules to confirm and it does indeed fix this case.