Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Liquid 4.0.0 again. #637

Closed
3 tasks done
hiroyuki-sato opened this issue May 18, 2017 · 3 comments
Closed
3 tasks done

Update Liquid 4.0.0 again. #637

hiroyuki-sato opened this issue May 18, 2017 · 3 comments

Comments

@hiroyuki-sato
Copy link
Contributor

hiroyuki-sato commented May 18, 2017 •
edited

For fix issue #586 It needs update Liquid to 4.0.0.
However, it has regression #627.
I investigated this on #635. Finally, I found the cause relates JRuby.
jruby/jruby#4611

After JRuby issue resolve, I'll update Liquid again.
@hiroyuki-sato hiroyuki-sato mentioned this issue May 18, 2017
Closed
@hiroyuki-sato hiroyuki-sato mentioned this issue Jun 9, 2017
Closed
@hiroyuki-sato
Copy link
Contributor Author

Update
The JRuby master branch fixed this issue. jruby/jruby#4658
It labeled 9.1.11.0 a milestone.
It means that the Embulk need to update 9.1.11 or newer.

@hiroyuki-sato hiroyuki-sato mentioned this issue Jun 15, 2017
Closed
@hiroyuki-sato hiroyuki-sato mentioned this issue Jun 25, 2017
Closed
@hiroyuki-sato
Copy link
Contributor Author

[Limitation] Digdag server and Liquid in Embulk.

@hiroyuki-sato hiroyuki-sato mentioned this issue Jul 19, 2017
Closed
@hiroyuki-sato hiroyuki-sato mentioned this issue Sep 20, 2017
Merged
@hiroyuki-sato
Copy link
Contributor Author

I made the PR #797. So I close this issue for avoiding confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hiroyuki-sato