Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: remove superagent and use XHR for the post request #86

Open
XhmikosR opened this issue Oct 27, 2019 · 5 comments
Open

frontend: remove superagent and use XHR for the post request #86

XhmikosR opened this issue Oct 27, 2019 · 5 comments

Comments

@XhmikosR
Copy link
Collaborator

No description provided.

@joelpurra
Copy link

joelpurra commented Apr 8, 2020

I agree, in particular since superagent is given special path treatment in index.js.

On my system /assets/superagent.js returns HTTP error 404 and breaks slackin-extended client-side. This is due to (changes in) how npm install places dependencies, which may be optimized between packages in the same package.json. I have a local hot-fix in place for now.

Versions

Am running slightly older versions due to apt on Debian 10 Buster.

node --version
v10.15.2
npm --version
6.14.4
Paths
npm ls superagent
slackin.joelpurra.com@1.0.0 .../slackin.joelpurra.com/public_html
└─┬ slackin-extended@2.1.0
  └── superagent@3.8.3 
ls --format=long --directory ./node_modules/{slackin-extended,superagent}
drwxr-xr-x 1 root root 116 Apr  8 16:56 ./node_modules/slackin-extended
drwxr-xr-x 1 root root 282 Apr  8 16:56 ./node_modules/superagent

Perhaps something like resolve-pkg could be used in the short-term, but replacing superagent with something else might be a better long-term solution.

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Apr 8, 2020

My suggestion would be to just drop the dependency but if it's easier feel free to submit a PR with resolve-pkg. You should make a new issue about it BTW

@joelpurra
Copy link

@XhmikosR: no rush for me, as I have a local hotfix in place. Will await a proper solution before upgrading.

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Apr 8, 2020

As you wish, but this issue is not about the issue you have, which is a bug I introduced for what is worth. I'll try to have a look in the next days but this deserves its own issue.

@joelpurra
Copy link

@XhmikosR: true, it's not the same issue. See #185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants