Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openpgp.MessageDetails footguns #5

Open
emersion opened this issue Feb 14, 2020 · 1 comment
Open

Fix openpgp.MessageDetails footguns #5

emersion opened this issue Feb 14, 2020 · 1 comment

Comments

@emersion
Copy link
Owner

emersion commented Feb 14, 2020 •
edited
Loading

Either populate SignatureError with an error before verification is complete, or switch to our own type.
@emersion
Copy link
Owner Author

emersion commented Mar 3, 2020 •
edited
Loading

Another footgun: when the signature issuer is unknown, SignatureError is nil but nothing has been verified. The only way to know is to check that SignedBy isn't nil.

@emersion emersion mentioned this issue Dec 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emersion