Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mako doesn't expose desktop-entry field #243

Closed
lovesegfault opened this issue Mar 17, 2020 · 3 comments
Closed

Mako doesn't expose desktop-entry field #243

lovesegfault opened this issue Mar 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@lovesegfault
Copy link

While investigating an issue with Lollypop notifications not setting app_name, we found that glib's notification backend does not set app_name at all and that, instead, it sets desktop-entry.

I believe mako should parse/expose this field as well.
@emersion emersion added the enhancement New feature or request label Mar 17, 2020
@emersion
Copy link
Owner

Yup. We should document all of that too, it's not eady to understand what these fields mean.

@vilhalmer
Copy link
Collaborator

FWIW this has been supported since we added criteria. I agree we should add some descriptions to the man page though.

@lovesegfault
Copy link
Author

The underlying issue in glib has been fixed: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vilhalmer @emersion @lovesegfault