New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration problem with wofi output selector for screen sharing #124
Comments
Related #121 and emersion/slurp#83 |
@columbarius Do you know anything about wofi configs and argument/config precedence w.r.t. this issue? Can we reproduce this outside of xdpw, making this an upstream bug? |
@danshick I don't know about this issue and i can't really reproduce it even with xdpw. @robertjk may you send me your wofi config (or the relevant part)? I don't use a config file and just adding an empty one with the line
|
Good idea! Created #125. I sticked to the xdg-desktop-portal language using monitor and window instead of output. |
Okay, so I did some more testing. 1. No wofi configuration, no xdg-desktop-portal configurationFirst I tried without Screen sharing doesn't work. Wofi prompt to select an output is never shown.
2. With wofi configuration, no xdg-desktop-portal-wlr configuration
Screensharing doesn't work: Wofi prompt to select an output is never shown.
3. No wofi configuration, with xdg-desktop-portal-wlr configuration
Screen sharing does work. Wofi prompt to select an output is shown. 4. With wofi configuration, with xdg-desktop-portal-wlr configurationBoth Screen sharing does work. Wofi prompt to select an output is shown. ImplicationsSo it seems I was wrong to assume it was the fault of
With this configuration present, a prompt to select an output is shown and screen sharing works fine. Without it, it's never shown and it doesn't work. Seems Should we pursuse this further, or is it somehow expected and it's not a bug? |
That's a bug and was fixed in #114. |
Then I'm closing this. Sorry for the unnecessary alarm. |
No problem. Thanks @columbarius. |
I had a problem with screen sharing not working for me in Google Hangouts. I'm using Arch, Sway (version 1.6), Firefox Developer Edition (89.0b6),
xdg-desktop-portal-wlr
package (0.3.0-1).wofi
configurationI found out that the root of the problem was
wofi
configuration. As soon as I set the following in~/.config/xdg-desktop-portal-wlr/config
things work fine:Which is weird, because even though I used to have
show=drun
in my~/.config/wofi/config
I see in code in this repo you explicitly callwofi
with-d -n
flags, which should forcewofi
to run indmenu
mode ignoring the value from my personal configuration.Should I debug that further?
Everything works fine for me now, but I thought I might report this as an issue, so that other people can benefit from the fix. Please tell me, if you're interested in fixing that, and if you are I can debug that futher.
Idea: Default prompt text
I think it might be nice to add some default prompt text to display when showing output selector. In
wofi
you pass that using--prompt
argument. I'm pretty sureslurp
andbemenu
might have similar parameters. I pass mine as Select the output to share.The text was updated successfully, but these errors were encountered: