You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.
When a rental is terminated, function createLease allows to opportunistically create a new rental (for the same listing) and an event RentEnds is emitted which so far indicates also fees are completely claimed which could not be the case.
Rentals with available fees to be claimed are not shown in the rentals list if a new rental for the same listing is created. This prevents user to claim these fees through the frontend (they should make a direct call to the smart contract).
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a rental is terminated, function
createLease
allows to opportunistically create a new rental (for the same listing) and an eventRentEnds
is emitted which so far indicates also fees are completely claimed which could not be the case.https://github.com/rentable-world/rentable-protocol/blob/694d4b1f3546d8b0a80904bcaedeca2d64eeac62/contracts/Rentable.sol#L211-L230
Possible solutions
availableToClaim
to 0 inhandleRentEnds
(see: https://github.com/rentable-world/rentable-subgraph/blob/e47633efa4dda86a70b972b5e3ae2790f9e4a4ae/src/mappings.ts#L136-L145)Impact on users
Rentals with available fees to be claimed are not shown in the rentals list if a new rental for the same listing is created. This prevents user to claim these fees through the frontend (they should make a direct call to the smart contract).
The text was updated successfully, but these errors were encountered: