List structure #2
Conversation
There was a problem hiding this comment.
Hi @emiliazm,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✅ Linters are passing
✅ Descriptive pull request
✅ Good commit messages
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -0,0 +1,20 @@ | |||
| let tasks = []; | |||
| export const getTasks = () => tasks; | |||
There was a problem hiding this comment.
- I can see that you try to implement the get task function here, however it is not working as it should, because every time it is called, what you get is an empty array. Kindly make sure it is getting the task from the local storage.
| liToTasks.innerHTML = insideUl; | ||
| liToTasks.querySelector('.lb-task').onclick = uiClickLabel; | ||
| liToTasks.querySelector('.ta-task').onblur = uiBlurTextArea; | ||
| liToTasks.querySelector('.trash').onclick = uiRemoveTask; |
There was a problem hiding this comment.
- [Optional] It will be nice if the delete button is visible on the page without editing or when the three dots is hovered. presently, one can only see the delete button when editing.
| const uiCreateTask = (task) => { | ||
| const tasks = getTasks(); | ||
| tasks.sort((a, b) => a.index - b.index); | ||
| const ulList = document.querySelector('.check-list'); | ||
| const insideUl = ` | ||
| <input id="ck-${task.id}" type="checkbox" name="checkBox"> | ||
| <label class="lb-task" id="lb-${task.id}" for="ta-${task.id}">${task.description}</label> | ||
| <textarea id="ta-${task.id}" class="ta-task" name="edit-task">${task.description}</textarea> | ||
| <span class="dots material-symbols-outlined">more_vert</span> | ||
| <span class="trash material-symbols-outlined">delete</span> | ||
| `; |
There was a problem hiding this comment.
- Kindly make sure that when the page reloads, the saved todo is rendered
|
Hello @phelian23 ! Thank you for your comments! These are the changes that I implemented:
|
There was a problem hiding this comment.
Hi @emiliazm, 👋
Highlights 👏
- Great work using the right GitHub Flow.
- Your README looks professional, well done!
- Commits are descriptive, good work.
- Linters are working properly, great job!
Your project is complete! There is nothing else to say other than... it's time to merge it! 🚀
Very nice work, congratulations! 🎉
APPROVED! 💯 💯 💯
Cheers and Happy coding! 🤓
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello!
These are the changes that I implemented: