Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile on VS2015 #5

Closed
skyline75489 opened this issue May 15, 2017 · 1 comment
Closed

Compile on VS2015 #5

skyline75489 opened this issue May 15, 2017 · 1 comment

Comments

@skyline75489
Copy link
Contributor

Big thanks for making this project & sharing it with the rest of us.

I'm working on Windows and I've managed to make this compile with VS2015. The changes are actually very limited.

First, VC++ doesn't recognize __attribute so __attribute__((noreturn)) cannot be used. The alternative is __declspec(noreturn) but it requires to be placed at the beginning for declaration like this:

__declspec(noreturn) extern void fatal () {}  

Second and isn't recognized as keyword so we need to use &&.

And last there's min/max macro defined somewhere in windows.h and causing name collision.

My commit is https://github.com/skyline75489/Configuru/commit/777795ee3bd54df268ab5aca758ef64ca43eaa7e

If it looks OK to u I can send you a PR. 🥂

@emilk
Copy link
Owner

emilk commented May 21, 2017

You are welcome, and thank you for your contribution! It has been merged to master in 6a703a5

@emilk emilk closed this as completed May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants