Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimium chrome plugin prevents text editing in web feature demo #8

Closed
jgarvin opened this issue Jul 21, 2020 · 6 comments
Closed

Vimium chrome plugin prevents text editing in web feature demo #8

jgarvin opened this issue Jul 21, 2020 · 6 comments
Labels
accessibility More accessible to e.g. the visually impaired help wanted Extra attention is needed web Related to running Egui on the web

Comments

@jgarvin
Copy link

jgarvin commented Jul 21, 2020

Vimium if you aren't already familiar is a plug-in that listens for particular keypresses so that you can navigate links in your web browser just using the keyboard. Normally it plays well with web forms, only intercepting keypresses when a form isn't selected. However when I click inside the input box in the demo, all of my keypresses are still being captured by Vimium, so I can't actually type anything. It seems there is some "you are in an editing field" state that doesn't get communicated back to the browser. I'm not sure if you would consider fixing this in scope but I could see it being a barrier for using emigui for non-game web apps, where plugins may be relevant for accessibility. I use Vimium so I can navigate webpages with a finite speech recognition command set (only letters like "A", "F" etc need to be recognized to be able to verbally click around). My guess is the current state of web assembly API standardization would make fixing this a horror show but I thought I'd mention it in case it's not ;)

@emilk emilk added help wanted Extra attention is needed web Related to running Egui on the web labels Jul 30, 2020
@iostapyshyn
Copy link

Might be related, when I'm trying to edit text in the demo, pressing backspace causes the browser to go back in history. Firefox 81.0.2 on Mac 10.15.7

@jgarvin
Copy link
Author

jgarvin commented Dec 27, 2020

Note this issue also prevents editing text on mobile. The browser can't tell you're in a text field so the keyboard never appears.

@anderspitman
Copy link

anderspitman commented Jan 12, 2021

To be fair, I find quite a few sites (including google properties) break Vimium, and I usually just disable it for the site and move on. In general I have much less expectation for Vimium to work for web apps than for web documents, which is usually fine since apps often have more custom navigation and interaction.

Not saying there aren't still things that can be improved.

@emilk emilk added the accessibility More accessible to e.g. the visually impaired label Feb 20, 2021
@emilk
Copy link
Owner

emilk commented Sep 30, 2021

Is this still an issue?

@jgarvin
Copy link
Author

jgarvin commented Sep 30, 2021

I tried two things:

  • In chrome w/ vimium, try pressing F (highlights links) with no text input having focus. As expected it found no links to click on. Then I opened the easymark editor and pressed F, and as desired it actually typed it! So main problem fixed. For accessibility it would be even better if pressing F without input focus actually highlighted the clickable GUI elements like it does on a regular web page, I assume this requires somehow tricking the browser into thinking there are links at these locations. But that should probably be its own issue?
  • I opened the demo on my android phone, clicked the easy mark editor and confirmed keyboard pops up as expected! But then, strangely, my phone started reading outloud all the text in the editor with text-to-speech, which I've never configured or used. Not sure if that's egui or something weird with my phone.

@emilk
Copy link
Owner

emilk commented Oct 2, 2021

For accessibility it would be even better if pressing F without input focus actually highlighted the clickable GUI elements like it does on a regular web page, I assume this requires somehow tricking the browser into thinking there are links at these locations. But that should probably be its own issue?

Yeah, let's do that as it's own issue as it is quite separate from text input.

my phone started reading outloud all the text in the editor with text-to-speech

This is part of egui/eframe - you can toggle it at the bottom of the backend panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility More accessible to e.g. the visually impaired help wanted Extra attention is needed web Related to running Egui on the web
Projects
None yet
Development

No branches or pull requests

4 participants