-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-touch drag gesture #6
Comments
Ran into the same issue. When I tried to pinch zoom the drawer just jumps around. |
I've tested it. Multi-touch works fine until your second touch is on the drawer. But if your second touch is above the drawer it should maintain the position. @umar-ahmed But still seems like having the support for maintaining the drag position with multi-touch gestures would be a nice addition 👍🏼 |
What is the real use case for this? It seems like an edge case. |
@umar-ahmed |
The main reason to consider this is to match behavior of drawers in native mobile OSes like iOS and Android. For touch interfaces, there's a soft expectation that things like this "just work" as you expect them to. That could be as simple as ignoring the second touch. I'm typing this out on the GitHub Mobile app for example and the comment drawer exhibits this behavior, only the first touch is recognized. My main concern was the flickering on the second touch. |
I mean, when do you do that second touch? I can imagine it on big screen, like iPad but still by just by mistake. |
That's a valid point @umar-ahmed and I agree that it should behave like native mobile OSes. This is definitely on the roadmap! |
We now handle multi touch thanks to #137. I won't support multi touch, but rather just ignore the second touch. iOS doesn't support pinch to zoom in a drawer, and thinking about it, it would be very hard to implement right. Mainly, because it's hard to know the right user intent. For now, ignoring all touches after the first one seems like a good solution. |
Makes sense to me, thanks! |
Starting a drag gesture with a single finger and then initiating another touch causes the drawer to jump. I'd expect for the drawer to maintain it's position and upgrade to a multi-touch gesture. I've recorded the following video on an Android phone to demonstrate:
screen-20230726-154152.2.mp4
The text was updated successfully, but these errors were encountered: