Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with left indent. Added shadow support. #10

Closed
wants to merge 11 commits into from

Conversation

parkin
Copy link
Contributor

@parkin parkin commented Jan 17, 2014

If the sticky view has padding to the left of it, it will now not lose that when it becomes stuck.

Added ability to set a shadow drawable that is drawn under the sticky heads.

@parkin parkin mentioned this pull request Jan 17, 2014
@emilsjolander
Copy link
Owner

Cool! Could you please also ad the ability to sit the shadow image and shadow height via xml?

@parkin
Copy link
Contributor Author

parkin commented Jan 18, 2014

Done. Let me know if I should do anything else!

Also, sorry for lumping shadow support and left indent fixes into the same pull request. Would you like me to split up each feature and bug fix into it's own pull request?

@emilsjolander
Copy link
Owner

Yes splitting them up would be great! thanks you :)

@parkin parkin closed this Jan 19, 2014
@parkin
Copy link
Contributor Author

parkin commented Jan 19, 2014

OK, I split them up into the left indent bug fix #11 and the shadow feature #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants