Fix: views might be null during onLayout. #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try to calculate dimensions of a view that might become null during layout (say if we are removing views)
|
This is still a problem |
|
Is this still a bug or not? I'm wondering because you didn't reopen the issue |
|
It is still a bug, see #14. I thought this pull request had fixed the bug, but the bug persisted, so I want to forget about this pull request. Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added flag set to true during onLayout. The flag is used so we don't try to calculate dimensions of a view that might become null during layout (say if we are removing views).
I was getting this error when I removed views from the ScrollView's child and the get_ForViewRelativeOnlyChild methods were being called. During onLayout, the views that get_ForViewRelativeOnlyChild is trying to calculate the dimensions of might become null. So we should just return zero from get*ForViewRelativeOnlyChild during this time, as the info is likely garbage anyway.