Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how the Postgres connector could only practically connect to localhost #28

Merged
merged 10 commits into from Sep 3, 2015

Conversation

crccheck
Copy link

@crccheck crccheck commented Sep 2, 2015

Tis ont erpefct, but now fake2db actually works for me now.

I tried to make this a minimal change, but there were some things I could not overlook, so there's some extra changes not related to the ability to pass in username/password.

Tested locally with:

$ fake2db --db postgresql --rows 1337 --host elk_postgres.local --password password --user docker
2015-09-02 17:19:25,854 crccheck      Rows argument : 1337
2015-09-02 17:19:36,184 crccheck      Database created and opened succesfully: postgresql_vsgjqwju
2015-09-02 17:19:38,134 crccheck      simple_registration Commits are successful after write job!
2015-09-02 17:19:39,864 crccheck      detailed_registration Commits are successful after write job!
2015-09-02 17:19:41,488 crccheck      companies Commits are successful after write job!
2015-09-02 17:19:42,958 crccheck      user_agent Commits are successful after write job!
2015-09-02 17:19:45,376 crccheck      customer Commits are successful after write job!

@emirozer
Copy link
Owner

emirozer commented Sep 3, 2015

Thank you very much for your contribution 👍
The whitespace thing is kind of weird.. what do you use for formatting?
I run my python code through https://github.com/google/yapf

emirozer added a commit that referenced this pull request Sep 3, 2015
Fix how the Postgres connector could only practically connect to localhost
@emirozer emirozer merged commit d995423 into emirozer:master Sep 3, 2015
@crccheck crccheck deleted the arggggs-matey branch September 3, 2015 16:53
@crccheck
Copy link
Author

crccheck commented Sep 3, 2015

I use sublime text and vim. For my style, I have an .editorconfig at my root with trim_trailing_whitespace: true

Before .editorconfig, I set it individually for my editors, but with this, I can set my style per project and editor agnostic.

http://editorconfig.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants