Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the database initialize process, and fix the bug that --name is… #38

Merged
merged 1 commit into from Jan 7, 2018

Conversation

huyx
Copy link

@huyx huyx commented Dec 2, 2017

When I use the following command:

fake2db --db sqlite --name test.db --rows 100

Instead of using test.db as the database file name, fake2db use a generated filename such as sqlite_JZMYNRKM.db.

I hope I had fixed the problem, but it is not full tested for other engine(postgresql, mysql, ...).

Thanks a lot.

@bhrgu
Copy link
Contributor

bhrgu commented Jan 3, 2018

Hi!
Your PR looks like a bugfix for #35.
I ran few tests with your code locally for SQLite and MySQL with no errors (except #39). BTW, PostgreSQL doesn't affected by this issue.

@emirozer
Copy link
Owner

emirozer commented Jan 7, 2018

Thanks for the PR, I will be releasing a new version this week. This pr will be included

@emirozer emirozer merged commit 4f6686f into emirozer:master Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants