helm-chart: Flexibility to add extra custom relabelling config for serviceMonitor
#5511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
helm-chart update
Extra variable in
values.yaml
metrics.serviceMonitor.relabelings
and templating toggle in theserviceMonitor
templateThis will allow us to add extra labels to prometheus metrics exposed by addition to
scrape_config
for the jobFixes: #5510
Related Issues
Ability to use custom relabelling for all prometheus metrics exported by emissary.
Since we use the upstream chart and just customise it using the values.yaml
Testing
As per the documentation
make test make gotest make pytest make lint
additional
Also updated the
CHANGELOG.md
withmake generate
Checklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.