Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot override name with nameOverride when the release name is ambassador #5575

Open
dhamkannan opened this issue Feb 16, 2024 · 0 comments
Labels
t:feature New feature or enhancement request

Comments

@dhamkannan
Copy link

Describe the bug

With emissary-ingress helm-charts, we cannot override the name with nameOverride when the release name is ambassador.

With the below mentioned tpl function, the {{- if contains "ambassador" .Release.Name -}} always get executed and never able to override the name

{{/*
Expand the name of the chart.
*/}}
{{- define "ambassador.name" -}}
{{- if contains "ambassador" .Release.Name -}}
{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

To Reproduce
Steps to reproduce the behavior:
Deploy emissary-ingress with release name as ambassador and override with differentname
You cannot rename the below lebel which is used by selectors on the service. It is a problem when you manage multiple emissary ingress with dependent charts where the release name is ambassador.
app.kubernetes.io/name: ambassador

Expected behavior

The nameoveride should come as the first condition on the if statement, because this is submitted optionally. And the release name should go as default.

Additional context
Add any other context about the problem here.

@cindymullins-dw cindymullins-dw added the t:feature New feature or enhancement request label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants