Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exp api #25

Merged
merged 31 commits into from Aug 7, 2021
Merged

Exp api #25

merged 31 commits into from Aug 7, 2021

Conversation

emjun
Copy link
Owner

@emjun emjun commented Aug 7, 2021

This branch introduces API redesigns/re-implementation, specifically:

  • Introduce three data types: Units, Measures, and SetUp variables
  • Updated the API to follow more OOP conventions so that measures must be declared through a unit. This enables us to enforce more valid programs/declarations at the API level, effectively enforcing automatically/removing the need to manually check for data measurement relationships between units and measures (was previously another step of compilation)
  • Add more tests for the new API
  • Start implementing new graph inference rules (this should have been a separate branch. Further development will occur on a separate branch.)
  • Update README to reflect the above changes.

emjun and others added 30 commits July 20, 2021 15:18
@emjun
In middle of refactoring variable API
63bd474
@emjun
Add notes and comments from Rene meeting
eeffddb
@emjun
Update gitignore
cbfc440
@emjun
Add overview, initial pass of corresponding Tisane program.
bdfb980
@emjun
Revise overview notes and ideas
028c2d4
@emjun
Update test graph tests
4c67674
@emjun
Add to examples
f8a1a6b
@emjun
Remove comments
03ba9ae
@emjun
Update test case
64c49d4
@emjun
Add Radon example files
fbca408
@emjun
Add comments and notes for next steps
9246b92
@emjun
Edit example Tisane programs, include comments that translate the lin…
7c0bc85 
…es of code into English
@emjun
Refactoring
200b726
@audreyseo @emjun
Add basic tikz graph creation (#24)
d2dc160 
* Add tikz graph

* Add tikz graph stuff

* Reformat

Co-authored-by: Eunice Jun <eunice.m.jun@gmail.com>
@emjun
Refactoring API
79fd751
@emjun
Add SetUp type, update test_variable tests to match new API, debug
b9c45b8
@emjun
Writing and re-implementing graph inference algorithms
149f383
@emjun
Add text/pseudocode for inference rules and tests
29e6a8f
@emjun
Start implementation model effect inference
a82e6ed
@emjun
Add first pass implementation of main effects generation
4055ccb
@emjun
Add tests and debug for finding common causal ancestors
852cedb
@emjun
Add tests for finding causal ancestors
5420a16
@emjun
Add more tests for finding variables associated with ivs that also ca…
4b0af8b 
…use or are associated with the dv
@emjun
Add more tests
54d2870
@emjun
Add tests for finding parents that cause an IV and also cause or are …
5a0f369 
…associated with the DV
@emjun
Update method name to match rule
c2370a3
@emjun
Update infer main effects method
16cedbd
@emjun
Add ivs already included in query to main effects candidates
9852f6b
@emjun
Add comment and return type to function signature for main effects in…
79b3274 
…ference
@emjun
Update README for new API
8a9d71b
@github-actions github-actions bot merged commit d7e7d91 into main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emjun @audreyseo