-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poller breaks on minification #31
Comments
When using a minified version from cdnjs there is no problem. Take a look. |
I was using the non-minified version and minifying it myself as I'm using Grunt to perform minification (uglify and mangling to be precise, the latter being the issue as it changes variables names). |
If you plumb in ngAnnotate before you uglify you should be ok. This places the dependencies in the array notation etc... |
@justingrayston Thanks, I'll surely end up using ngAnnotate (even if in the beginning I was trying to avoid using that). My project uses several external modules with the uglify issue due to services declaration syntax and in fact it seems it would take more effort to fork and get pull requests integrated than simply set up ngAnnotate to fix the problem :-) |
@AnimaLupi: Merged. Thanks for the PR!:-) |
Hello,
when using minification the dependency injection fails.
It could be easily fixed by using the inline annotation, I tried making a pull request (did the fix directly online in github, so hopefully I placed the closing square brakets in the right places :-)
#30
Hope it can be used, ciao!
The text was updated successfully, but these errors were encountered: