More colours ✨ #11
Merged
More colours ✨ #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SimonMarquis
commented
Sep 27, 2014
SimonMarquis
commented
- Add more colors (from http://developer.android.com/design/style/color.html)
- Split user defined colors and default colors
- Ordered color list (user defined colors first)
- Simplify the "Add new colour" dialog
- Colours are validated by Color.parseColor(String) and therefore more flexible
- FloatLabelLayout from @chrisbanes (https://gist.github.com/chrisbanes/11247418)
- Delete user defined colours
….html). Split user defined colors and default colors. Ordered color list (user defined colors first).
Colours are validated by Color.parseColor(String) and therefore more flexible FloatLabelLayout from @chrisbanes (https://gist.github.com/chrisbanes/11247418)
| <item>@string/green</item> | ||
| <item>@string/yellow</item> | ||
| <item>@string/red</item> | ||
| <item>@string/red</item> |
There was a problem hiding this comment.
Is red meant to be here twice? When I run the app I only see it once
There was a problem hiding this comment.
It was a mistake.
|
Looks great - thanks very much :) 👍 |
emmaguy
added a commit
that referenced
this pull request
Sep 28, 2014
…ours are set in colourprefs if there's nothing saved, otherwise behave as any other user added colour as there were some issues - users could not delete default colours, app was crashing when trying to delete default colour, were also duplicates of black/white when upgrading from older version. Also slightly improved dialog to only enable the add button when both name and valid colour have been set
emmaguy
added a commit
that referenced
this pull request
Sep 28, 2014
…ours are set in colourprefs if there's nothing saved, otherwise behave as any other user added colour as there were some issues - users could not delete default colours, app was crashing when trying to delete default colour, were also duplicates of black/white when upgrading from older version. Also slightly improved dialog to only enable the add button when both name and valid colour have been set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.