Defining aliases breaks the build

[Martin-Narvar]

My .circleci/config.yml contains

version: 2.1

setup: true

orbs:
  dynamic: bjd2385/dynamic-continuation@3.7.1

workflows:
  generate-config:
    jobs:
      - dynamic/continue:
          name: Generate configs
          context: orb-publishing
          default-branch: master
          modules: |
            /java
            /typescript
            /golang

I created corresponding java.yml, golang.yml and typescript.yml files, and the orb does merge them correctly.

However my java.yaml contains aliases of the form

aliases:
  - &defaults
    docker:
      - image: $DOCKER_REPO/alpine-oraclejdk8:3.11-202-master
    working_directory: ~/soil-core

That are uses elsewhere in the script like this:

jobs:
  build_java:
    <<: *defaults
    steps:
      - checkout

During the merge, validation fails with

Error: config compilation contains errors: config compilation contains errors:
        - Unable to parse YAML
        - found undefined alias defaults
        -  in 'string', line 19, column 9:
        -         <<: *defaults
        -             ^

I think this is because this dynamic continuation orb moves all of the aliases to the end of the script.

[emmeowzing]

@Martin-Narvar sounds like I'd want to explode prior to reduction.

https://mikefarah.gitbook.io/yq/operators/anchor-and-alias-operators

I can cut a v3.8.1 with this fix.

[Martin-Narvar]

That would be fantastic. Aliases are essential for DRY

[emmeowzing]

@Martin-Narvar please check out v3.8.1. I implemented a fix for this issue and a form of testing in #108.

[Martin-Narvar]

With this version I get an error

Error calling job: 'dynamic/continue'
Unexpected argument(s): default-branch

Did you rename this option since 1.7.1

[Martin-Narvar]

I changed default-branch to base-revision and now it works as expected.
Thank you so much.