Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate workflow IDs across pipelines' manifests don't raise errors #73

Open
emmeowzing opened this issue Jun 4, 2023 · 1 comment
Open

Duplicate workflow IDs across pipelines' manifests don't raise errors #73

emmeowzing opened this issue Jun 4, 2023 · 1 comment
Labels
bug An issue with the system 🐛.

Comments

@emmeowzing
Copy link
Owner

They just overwrite each other. I think I should error on this and warn users to ensure there's no confusion. It's easy with this orb to start copying similar pipeline manifests, and just as easy to forget to update the pipeline's workflow IDs so they're now different.
@emmeowzing emmeowzing added bug An issue with the system 🐛. Improvement labels Jun 4, 2023
@emmeowzing
Copy link
Owner Author

emmeowzing commented Jun 5, 2023 •
edited
Loading

Duplicate orb aliases w/different orb version references should be errored on as well prior to merging configs. Otherwise it'll just take the last one and it'd be rather confusing why something was referencing only one of the versions in the generated config.

@settings settings bot removed the Improvement label Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue with the system 🐛.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emmeowzing