Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use 'main' instead of master? #89

Closed
szeitlin opened this issue Aug 18, 2023 · 3 comments · Fixed by #90
Closed

update to use 'main' instead of master? #89

szeitlin opened this issue Aug 18, 2023 · 3 comments · Fixed by #90
Assignees

Comments

@szeitlin
Copy link

The filter step is able to detect my modules (yay!) but I'm getting fatal: ambiguous argument 'master': unknown revision or path not in the working tree., I think because modern repos all use main instead of master ? Not sure if this is in your code or CircleCI's, so feel free to tell me to go make a ticket there instead (or in addition).

@emmeowzing emmeowzing self-assigned this Aug 21, 2023
@emmeowzing
Copy link
Owner

Hello @szeitlin , yes this is defaulted to master. I can update it in the next release to main. You can fix this by specifying the default branch, such as

setup: true

orbs:
  dynamic: bjd2385/dynamic-continuation@<version>

workflows:
  on-commit:
    jobs:
      - dynamic/continue:
          context: circleci
          default-branch: main

@emmeowzing emmeowzing linked a pull request Aug 21, 2023 that will close this issue
@emmeowzing
Copy link
Owner

Default branch of this repo & default branch of the job have been updated. I'll cut a release 3.7.0 with these changes.

@szeitlin
Copy link
Author

awesome, thank you for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants