-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Everything just stop working #50
Comments
{
"config": {
"stylesheet": {
"snippets": {
// Your custom snippets here
"foo": "foo-bar"
}
}
}
}
|
Added README with custom snippets examples: https://github.com/emmetio/sublime-text-plugin#adding-custom-emmet-snippets |
I found few others changes or bugs, but I left this behind me - it is just too much to change workflow all this years... |
Last thing - in CSS/SASS files abbrevation works only after I hit SPACE. |
Same here, everything stop working since last update |
ok i just understood that you had to use the TAB key |
Just tried with PHP syntax: wrote
Works fine for me. Maybe you created custom snippet for
Can you show me your
Fixed in v2.1.2 |
I'm noticing that Emmet is now super overzealous about tab completion. |
@mrcsmcln please check your keybindings, did you changed Tab key handler for |
After uninstalling and reinstalling, Emmet works great. Not sure why that needed to happen, as I didn't modify any other settings. |
Maybe old version wasn’t correctly unloaded. Anyway, new version should work better with native snippets |
@sergeche I concur, so many things stopped working since this update, mostly all the key bindings. I don't have ANY custom key bindings, they are all default. The biggest ones I use nearly on the hour no longer work:
Do I need to define these myself now? Or what else can I check? |
@cheestudio Yes, you have to specify your own shortcuts: https://github.com/emmetio/sublime-text-plugin#more-actions |
Sigh. OK. Do you happen to have a default set of those defined that I can copy/paste of the ones you removed? Kind of frustrating to have to map those myself when they've been defined all along... |
@cheestudio Lots of people were complaining that Emmet redefined default ST actions or actions from another extension. I'll add sample file with shortcuts later |
Totally, I see why you made the change. Painful in the meantime, but a good change in the long run. But a sample file would be absolutely awesome! |
The example key bindings could just be included in the default included key bindings configuration, just commented out. That would make it easy to just copy them to user keybindings and uncomment. |
Yeah, that's true and Your work is amazing. But after this years and stable configuration it's really hard to change habits in one second. |
@vellkan it’s not about changing habits, it‘s about spending a few minutes to tweak package for your needs |
Check out v2.1.3, there’s new menu item Preferences > Package Settings > Emmet > Key Bindings with shortcuts from previous version, which you can copy and uncomment |
I think it is about changing habits, because TAB no longer works as it did before. I now have to really pay attention to what syntax mode I'm in and use a combination of I added back all the previous key binding snippets but TAB still does not work in So, yes, I do have to change my coding habits. Or is there a way to install the previous version and prevent it from being autoupdated? |
It was a bug, fixed it in v2.1.8. You can mimic Tab key behaviour from previous version with the following keybinding: {
"keys": ["tab"],
"command": "emmet_expand_abbreviation",
"args": { "tab": true },
"context": [
{ "key": "emmet_capture_abbreviation" },
{ "key": "selection_empty" },
{ "key": "has_next_field", "operand": false },
{ "key": "auto_complete_visible", "operand": false },
{ "key": "selector", "operand": "source.css, source.sass, source.less, source.scss, source.stylus, source.postcss, source.jade, text.jade, source.pug, text.pug, text.slim, text.xml, text.html - source, text.haml, text.scala.html, source string" }
]
} But it’s not recommended, please report bugs you struggle with |
I appreciate Your work and last updates, but I can't back to previous workflow. I've even try to install ST and plugins from the beginning, but it didn't help. |
@vellkan Emmet config format has been changed, everything is available in README. If you have issues with snippets, you can send me your old config and I will help you |
I know, I've read them. Some of snippets works, some of them - don't work. And everyday I found more things which works differently. Now I'm testing Visual Studio Code, I'm considering to switch to another app. |
Please report things that doesn't work as expected |
Something I've noticed over the past couple days: Here's the Snippet |
@craigerskine native snippets should not be affected. Maybe you have custom Tab key binding that expands Emmet abbreviation? |
@sergeche Here's my key bindings. Is there something wrong with this? |
@craigerskine Oh, got it: Emmet detected that
|
@sergeche AWESOME! Thanks for your help. |
It's just a few of them. I remove all my CSS/SCSS plugins with snippets, reload them, nothing helps.
|
Im seeing the same issues as above. Im using emmet 2.1.14 with JavaScript (Babel). I can get the expansion to work with a This is my simple test case const foo = () => {
return (
div.foo>div.bar>h1{THIS DOESNT WORK}
);
}; const foo = () => {
return (
<div.foo>div.bar>h1{THIS WORKS}
);
}; |
@kirkegaard you should add key binding manually, see https://github.com/emmetio/sublime-text-plugin#more-actions |
Works for me, please check again with latest version
All snippets with operators like
Please provide more examples of snippets that doesn’t work
Should work with HTML syntaxes. If it still doesn’t please restart ST, open ST console and send me it’s contents
Please ensure you have the most recent Emmet version
It’s a default ST behaviour |
Hi @sergeche. I've been having some issues with the latest 2.1.16 as well. If that's a possible bug, hope this could help. SublimeText 3.2.2 Build 3211 |
@guimadaleno thanks for the report, looks like a bug. Could you create a separate issue so we can discuss it there? |
Hi @sergeche ! Before Emmet update:
After Emmet update:
... and a lot of such examples I've got. Also I can't find how to manage css.valueSeparator option. Previously it was "css.valueSeparator": ":" (without spaces after ":"), but now it doesn't work as well. Another question is how to create HTML snippet with caret position after abbreviation expanding? Sequence of caret position or highlight some code after expanding? For example: My old snippets and preferences: Thank you in advance :) |
@sergeche Thanks for respond - now I understand why some behaviors didn't work like I expect. But I've got same problem like @guimadaleno on his gif. I've try to describe this before, but visualisation is better :) |
I'm probably also in this camp. Ever since Emmet upgraded automatically, so many things broke in my ST3. I'm using TabNine AI-based code completion: https://www.tabnine.com/ Now it's not working well anymore. Emmet and TabNine are fighting for priority and I never know which one will complete when I press . Many other keyboard shortcuts are also broken and I'm not sure if this is related or not. Is there any way to revert, at least temporarily, to the previous verison? Thanks! |
@vfonic by default, Emmet now expands captured abbreviations only (they are underlined): https://github.com/emmetio/sublime-text-plugin#expanding-abbreviation And please, create new issue with detailed description where it’s not working anymore |
Today I get update and everything just stop worked :/
For now I need uninstall everything and try to re-configure everything again.
I now You've done great job, but for me - it ruined my day and all my workflow. Seriously, I just want to back to earlier version...
The text was updated successfully, but these errors were encountered: