Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small suggestions: Leaf iterations, remove asserts on enumerate empty tree. #1

Open
stuw-u opened this issue Jul 21, 2023 · 0 comments

Comments

@stuw-u
Copy link

stuw-u commented Jul 21, 2023

The title is pretty self-explanatory. I'm using your thing in my game, it's working well so far but I'm confused why it would throw an assert when trying to Enumerate on an empty tree. It would make more sense just to "yield break" and not enumerate on anything at all.

I'm also suggesting adding a leaf enumerator that returns the node's values directly. That way I can use the BVH tree as my collection to store my IBVH objects directly instead of letting the user manage two collections, one normal list/dictionary and a BVH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant