Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to disable the logging #101

Closed
Aeron opened this issue Jul 28, 2023 · 3 comments · Fixed by #122
Closed

Flag to disable the logging #101

Aeron opened this issue Jul 28, 2023 · 3 comments · Fixed by #122

Comments

@Aeron
Copy link
Contributor

Aeron commented Jul 28, 2023

Hey, the superb library you created here. I appreciate the effort very much.

Yet I am curious if there is a way to remove Granian logging, in case I like to control logging myself on the application level.

The only way I was quick to think of is to trick the log_dictconfig by supplying the {"root": {}} dictionary. (Yes, I am another guy who loves to run Granian programmatically, not by CLI.)

Will it be simpler to provide a separate CLI flag and a constructor argument for that?

@gi0baro
Copy link
Member

gi0baro commented Aug 18, 2023

Hi @Aeron, sorry for the late reply, I was AFK.

As of today there's no quick way to do so. Probably an additional flag for this would be the best option. You might want to open a PR for this?

@Aeron
Copy link
Contributor Author

Aeron commented Aug 26, 2023

If you’re okay with the proposal, then sure, I’ll gladly look into it when I have a moment 👍

@gi0baro
Copy link
Member

gi0baro commented Aug 26, 2023

If you’re okay with the proposal, then sure, I’ll gladly look into it when I have a moment 👍

Sure thing! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants