Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to drop mimalloc #121

Closed
gi0baro opened this issue Sep 4, 2023 · 2 comments
Closed

Consider to drop mimalloc #121

gi0baro opened this issue Sep 4, 2023 · 2 comments

Comments

@gi0baro
Copy link
Member

gi0baro commented Sep 4, 2023

Given

it seems mimalloc causes large virtual memory allocations.

Some quick tests on CPython 3.10 on Apple Silicon shows a few percentage points performance degradation (RPS) when switching to default allocator.

Before a drop/replacement action I'd like to make more tests on memory usage and performance degradation, gonna update this in the process.

@gi0baro gi0baro added this to the 0.6 milestone Sep 4, 2023
@Aeron
Copy link
Contributor

Aeron commented Sep 6, 2023

My two cents, if I may:

The latter might be irrelevant to any decision here, just a curious fact.

@gi0baro
Copy link
Member Author

gi0baro commented Sep 7, 2023

  • Mimalloc is still a viable solution for MUSL-based platforms since the default allocator there is not very efficient;

We can definitely use mimalloc just on MUSL builds.
Anyways, this is just a reminder for myself, before taking any decision I gonna update this with benchmarks and profiling results :)

@gi0baro gi0baro removed this from the 0.6 milestone Oct 16, 2023
@gi0baro gi0baro closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants