Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python code formatting and linting #123

Closed
Aeron opened this issue Sep 6, 2023 · 2 comments · Fixed by #124
Closed

Python code formatting and linting #123

Aeron opened this issue Sep 6, 2023 · 2 comments · Fixed by #124

Comments

@Aeron
Copy link
Contributor

Aeron commented Sep 6, 2023

Considering the more people contributing to the project, especially having #116, will it be appropriate to establish the formatting and linting rules for Python code? The obvious benefit is that no contributor will doubt what development tools and styles to apply.

I will gladly provide a configuration for tools like black, isort, and ruff, for a start at least.

While doing #122, I deactivated my black and ruff plugins because any file save immediately changes too many things I didn’t touch. And those two are the industry standard by now.

@gi0baro
Copy link
Member

gi0baro commented Sep 7, 2023

@Aeron it definitely makes sense.
If you don't mind, I gonna open a PR myself later today so I'll cover also the Rust part. I gonna ask a comment from you on that.

@gi0baro gi0baro mentioned this issue Sep 7, 2023
@gi0baro
Copy link
Member

gi0baro commented Sep 7, 2023

@Aeron I'd appreciate your feedbacks on #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants