Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the todo list structure #1

Merged
merged 13 commits into from May 5, 2022
Merged

Conversation

emmiiorji
Copy link
Owner

This change implements the structure of the todo list app.

  • Webpack is used to bundle the modules including the stylesheet.
  • The DOM is loaded with a dummy todo array from within the script.
  • The loading to the DOM happens on page load.

Find the screenshot below:

image

Kindly leave your comments and any suggested changes down below, they're appreciated.

Copy link

@Omar-Muhamad Omar-Muhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Required ♻️

Hi @emmiiorji,

Nice job, you are almost there.

(Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • Github flow is used correctly. ✔
  • All linters checks are ok. ✔

(Changes Required) Aspects to improve: ♻️

  • Please edit your README file adding (Project name, description, built with, getting started, authors, and license) you can use this template and edit it to fit your project.

[Optional] suggestions:

  • Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@BrianSammit BrianSammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🟢 👏

Hello @emmiiorji ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

TO HIGHLIGHT:

  • Your project is professional
  • Your repo is professional
  • Well structured files

Now you can merge this branch and move on 🥇
HAPPY CODING AND GOOD LUCK WITH THE COMMING ONES 🤞 🍀

well-1

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@emmiiorji emmiiorji merged commit 83c1848 into development May 5, 2022
@emmiiorji emmiiorji deleted the create-list-structure branch May 5, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants