Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the list more interactive #4

Merged
merged 10 commits into from May 9, 2022
Merged

Make the list more interactive #4

merged 10 commits into from May 9, 2022

Conversation

emmiiorji
Copy link
Owner

@emmiiorji emmiiorji commented May 6, 2022

This change implements some more functionalities for a better experience of the user.

Some highlights includes:

  • Each to-do list marked as completed is saved to the local storage.
  • The "clear all completed" button is now functional and clears all tasks marked as completed.
  • All changes are saved so the user gets the correct list values after the page reloads.

Here's a short video demo of the app:

todo_list_demo.mp4

Copy link

@Omar-Muhamad Omar-Muhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔

Hi @emmiiorji,

Great job, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

thumbs-up-agree

(Highlights) Good Points: 👍

  • You documented your work professionally. ✔
  • Github flow is used correctly. ✔
  • All linters checks are ok. ✔

(Changes Required) Aspects to improve: ♻️

  • N/A

[Optional] suggestions:

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

**Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@emmiiorji emmiiorji merged commit d6973d6 into development May 9, 2022
@emmiiorji emmiiorji deleted the make-interactive branch May 9, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants