-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could the function names clarify which ones perform an HTTP request? #64
Comments
@annakrystalli I was thinking about this whilst adding fixtures. It'd be nice to know at a glance which ones recycle info from say the client, and which ones don't. |
I have been thinking about this again.
|
@annakrystalli @salvafern what's your take on this? |
Related #53 |
Hi, I'm not aware of the best practices but seems like a valid point. Other packages use "download" instead of "get" indeed. |
I was inspired by the Art of Readable Code where they wrote "Many Programmers are used to the convention that methods starting with get are 'lightweight accessors' that simply return an internal member." But maybe we should follow ows4R lead to not confuse users 🤔 |
Well if you think it will improve the code readability I am all in! |
Notes
|
|
|
No description provided.
The text was updated successfully, but these errors were encountered: