Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eulfedora not compatible with requests 2.11.0 #25

Closed
cormier opened this issue Aug 8, 2016 · 3 comments
Closed

eulfedora not compatible with requests 2.11.0 #25

cormier opened this issue Aug 8, 2016 · 3 comments

Comments

@cormier
Copy link

cormier commented Aug 8, 2016

Since version 2.11.0 requests expects header attributes to be of type str or bytes:
https://github.com/kennethreitz/requests/blob/fb014560611f6ebb97e7deb03ad8336c3c8f2db1/requests/utils.py#L754

eulfedora specify the verify attribute as a bool:
https://github.com/emory-libraries/eulfedora/blob/master/eulfedora/api.py#L91

This causes requests to raise InvalidHeader exceptions when eulfedora uses it.

@rlskoeser
Copy link
Contributor

@cormier thanks for reporting. I just discovered this issue via the travis-ci build as I was working on the utf-8 issue raised in #22, and I already have a fix for it on that feature branch. Hopefully I'll be able to get that branch merged in and get a hotfix out soonish, just hoping to get someone else to verify the utf-8 fixes first.

@cormier
Copy link
Author

cormier commented Aug 8, 2016

Thanks for the quick reply! In that case I will not submit a fix and continue using requests 2.10.0 in the meantime.

@rlskoeser
Copy link
Contributor

Fixed in eulfedora 1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants