Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emotion/native's css method does not work for border-bottom. #1488

Closed
tian-yi opened this issue Sep 2, 2019 · 5 comments
Closed

emotion/native's css method does not work for border-bottom. #1488

tian-yi opened this issue Sep 2, 2019 · 5 comments

Comments

@tian-yi
Copy link
Contributor

tian-yi commented Sep 2, 2019

Current behavior:

<TextInput style={css`border-bottom: 1px solid gold;`} />

This does not apply any styles to the TextInput's bottom border. This does not work for other specific sides either like border-top, left or right

This works though:

<TextInput style={css` border-bottom-color: red; border-bottom-width: 1px;`} />

Using just border also works.

<TextInput style={css`border: 1px solid gold;`} />

Tested on the following versions of react, react-native, emotion and emotion/native

  • react version: 16.8, 16.9
  • react-native version: 0.59.8
  • emotion/core version: 10.0.14, 10.0.17
  • emotion/native version: 10.0.14
@tian-yi tian-yi changed the title emotion/native's css method does not work for border-bottom. emotion/native's css method does not work for border-bottom. Sep 2, 2019
@Andarist
Copy link
Member

Andarist commented Sep 2, 2019

Could you prepare a repository with the issue reproduced?

@tian-yi
Copy link
Contributor Author

tian-yi commented Sep 2, 2019

@Andarist
Copy link
Member

Andarist commented Sep 2, 2019

Please report this to https://github.com/styled-components/css-to-react-native , seems like they miss transform for those css properties and we are using this package to do the parsing.

EDIT: there is actually open PR for this - styled-components/css-to-react-native#95 , you can checkout the discussion there

@tian-yi
Copy link
Contributor Author

tian-yi commented Sep 2, 2019

Interesting, I understand the reason now why it's not working. But I wonder maybe somehow we can improve the documentation to reflect this.

@tian-yi
Copy link
Contributor Author

tian-yi commented Sep 4, 2019

So since this is not an emotion/native issue, I will close this. Thanks for your help @Andarist

@tian-yi tian-yi closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants