-
Notifications
You must be signed in to change notification settings - Fork 726
Conversation
amazing! will take a look tomorrow @pycui |
@jerryjliu maybe holding off a bit - after re-thinking about the limitations of current Google Keep API, I think it's not practical for most of users of Keep (the API frankly is not as productionized as Google Docs or Drives) . Would we be open to use "unofficial" API libraries (like https://github.com/kiwiz/gkeepapi which actually works better for normal user) in the hub? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerryjliu maybe holding off a bit - after re-thinking about the limitations of current Google Keep API, I think it's not practical for most of users of Keep (the API frankly is not as productionized as Google Docs or Drives) . Would we be open to use "unofficial" API libraries (like https://github.com/kiwiz/gkeepapi which actually works better for normal user) in the hub?
In general yeah we'd be open to unofficial library support. The goal of llamahub is really to give users a diversity of choices in getting started (hence why we have 7+ different pdf loaders), so I'd just pick one to start with. honestly i'm down to review/land this if it looks ok (as long as it works)
Sounds good I will switch to gkeepapi API given it works better for most. Will rerequest review once ready. |
sounds good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! some comments. also not sure why poetry.lock is modified
@jerryjliu can you or a maintainer help merge it? Thanks! |
Reads notes from Google Keep.
Note Google Keep's API only works if you have (1) Enterprise account (2) use Service Account to authenticate (3) a Domain-wide Delgation enabled for the service account with the Google Keep scopes - which requires a Google Workspace super admin to set up. Making it less useful for normal users.