Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add Google Keep Reader #370

Merged
merged 9 commits into from
Jul 15, 2023
Merged

Conversation

pycui
Copy link
Contributor

@pycui pycui commented Jul 10, 2023

Reads notes from Google Keep.
Note Google Keep's API only works if you have (1) Enterprise account (2) use Service Account to authenticate (3) a Domain-wide Delgation enabled for the service account with the Google Keep scopes - which requires a Google Workspace super admin to set up. Making it less useful for normal users.

@jerryjliu
Copy link
Collaborator

amazing! will take a look tomorrow @pycui

@pycui
Copy link
Contributor Author

pycui commented Jul 10, 2023

@jerryjliu maybe holding off a bit - after re-thinking about the limitations of current Google Keep API, I think it's not practical for most of users of Keep (the API frankly is not as productionized as Google Docs or Drives) . Would we be open to use "unofficial" API libraries (like https://github.com/kiwiz/gkeepapi which actually works better for normal user) in the hub?

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerryjliu maybe holding off a bit - after re-thinking about the limitations of current Google Keep API, I think it's not practical for most of users of Keep (the API frankly is not as productionized as Google Docs or Drives) . Would we be open to use "unofficial" API libraries (like https://github.com/kiwiz/gkeepapi which actually works better for normal user) in the hub?

In general yeah we'd be open to unofficial library support. The goal of llamahub is really to give users a diversity of choices in getting started (hence why we have 7+ different pdf loaders), so I'd just pick one to start with. honestly i'm down to review/land this if it looks ok (as long as it works)

llama_hub/google_keep/README.md Outdated Show resolved Hide resolved
@pycui
Copy link
Contributor Author

pycui commented Jul 12, 2023

In general yeah we'd be open to unofficial library support. The goal of llamahub is really to give users a diversity of choices in getting started (hence why we have 7+ different pdf loaders), so I'd just pick one to start with. honestly i'm down to review/land this if it looks ok (as long as it works)

Sounds good I will switch to gkeepapi API given it works better for most. Will rerequest review once ready.

@jerryjliu
Copy link
Collaborator

sounds good, thanks!

@pycui pycui requested a review from jerryjliu July 13, 2023 07:37
Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! some comments. also not sure why poetry.lock is modified

llama_hub/google_keep/README.md Outdated Show resolved Hide resolved
llama_hub/google_keep/base.py Outdated Show resolved Hide resolved
@pycui pycui requested a review from jerryjliu July 14, 2023 05:12
@pycui
Copy link
Contributor Author

pycui commented Jul 15, 2023

@jerryjliu can you or a maintainer help merge it? Thanks!

@jerryjliu jerryjliu merged commit 15820f9 into run-llama:main Jul 15, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants