Skip to content

Commit

Permalink
Update changelog, ignore search data attribute in arguments details m…
Browse files Browse the repository at this point in the history
…odal
  • Loading branch information
rwojsznis committed Mar 6, 2018
1 parent cb50fe7 commit b076f72
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 11 deletions.
25 changes: 17 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
## 0.3.0
## 0.4.0

Interface changes & maintenance, API untouched.

- reworked routes - `date` param removed in favor of named `day/:date` subroute
- simple search / filter added in UI panel (hijacks search command)
- tiny css tweaks
- run test on travis for sidekiq `4.2` and >= `5.1` and all newest rubies (`2.2` - `2.5`)

## 0.3.0 (June 14, 2017)

- require Sidekiq >= 4.2.0 (after Sinatra dependency was removed)

## 0.2.5
## 0.2.5 (December 14, 2015)

- add csrf tag for sidekiq >= 3.4.2
- **[BREAKING CHANGE]** don't load `sidekiq/web` automagically at
Expand All @@ -14,21 +23,21 @@ require 'sidekiq/web'
require 'sidekiq/expected_failures/web'
```

## 0.2.4
## 0.2.4 (July 23, 2014)

- `Sidekiq::ExpectedFailures.clear_old` can now accept argument - will remove failures
that are n days old (1 by default) - useful if you want to clear some of old failures
using cronjob

## 0.2.3
## 0.2.3 (May 07, 2014)

- removed (unnecessary) dependency on `Sidekiq::Util` (now Sidekiq 3.0 compatible)

## 0.2.2
## 0.2.2 (February 14, 2014)

- rescue load error of `sidekiq/web` (this allows client only usage)

## 0.2.1
## 0.2.1 (December 18, 2013 )

- added JSON stats path in case you would like to fetch this data from external service.
It works similar to sidekiq's _stats_. You can visit: `expected_failures/stats` to
Expand All @@ -45,7 +54,7 @@ require 'sidekiq/expected_failures/web'
}
```

## 0.2.0
## 0.2.0 (December 01, 2013)

- [**breaking change**] ability to use Sidekiq's build-in `handle_exception`
method - in case you want to use airbrake or other exception notify service.
Expand Down Expand Up @@ -79,6 +88,6 @@ discarded (for that worker).

- small front-end adjustments

## 0.0.1
## 0.0.1 (October 29, 2013)

- Initial release
4 changes: 2 additions & 2 deletions test/lib/web_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def create_sample_failure
it 'does not display counter div' do
create_sample_failure
get '/expected_failures'
last_response.body.wont_match(/dl-horizontal/)
last_response.body.wont_include('<dl class="dl-horizontal')
last_response.body.wont_match(/All counters/i)
end
end
Expand All @@ -114,7 +114,7 @@ def create_sample_failure

it 'displays counters' do
get '/expected_failures'
last_response.body.must_match(/dl-horizontal/)
last_response.body.must_include('<dl class="dl-horizontal')
last_response.body.must_match(/All counters/i)
end

Expand Down
4 changes: 3 additions & 1 deletion web/assets/expected.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
function mapDataAttributes(element) {
var html = "";
$.each(element.data(), function( key, value ) {
html += "<tr><th>Argument #" + key + "</th><td>" + value + "</td></tr>";
if (key != 'search') {
html += "<tr><th>Argument #" + key + "</th><td>" + value + "</td></tr>";
}
});
return html;
}
Expand Down

0 comments on commit b076f72

Please sign in to comment.