CI fix for topic reflection. #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdyWayne
force-pushed
the
herman/dev
branch
3 times, most recently
from
04349d4
to
ba1420c
Compare
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
OdyWayne
force-pushed
the
herman/dev
branch
from
ba1420c
to
64386da
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
OdyWayne
force-pushed
the
herman/dev
branch
from
c578d23
to
7b5a68f
Compare
|
More code needs to be adjusted for topic reflection, like rest api bridge sub & unsub. Before that tests for those are not available, so the codecov may go down. |
OdyWayne
force-pushed
the
herman/dev
branch
from
719652d
to
038274b
Compare
wanghaEMQ
reviewed
Sep 20, 2023
|
This PR is meant to fix the CI issue. As for the issue mentioned above, there will be another PR to fix it. |
RanMaoyi
approved these changes
Sep 20, 2023
OdyWayne
force-pushed
the
herman/dev
branch
2 times, most recently
from
a434a6b
to
26c4dae
Compare
Signed-off-by: Hermann0222 <yukang.wei@emqx.io>
OdyWayne
force-pushed
the
herman/dev
branch
from
26c4dae
to
b36e8fd
Compare
THE another PR --> #1455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.