Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* ADD [quic] Support mqttv5 over quic client #1453

Merged
merged 3 commits into from
Sep 22, 2023
Merged

* ADD [quic] Support mqttv5 over quic client #1453

merged 3 commits into from
Sep 22, 2023

Conversation

RanMaoyi
Copy link
Contributor

No description provided.

wanghaEMQ
wanghaEMQ approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@RanMaoyi RanMaoyi force-pushed the moi_quic branch 2 times, most recently from df9292a to dfaa813 Compare September 22, 2023 03:27
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited

Codecov Report

Patch coverage is 66.90% of modified lines.

❗ Current head dfaa813 differs from pull request most recent head 88c166b. Consider uploading reports for the commit 88c166b to get more accurate results

Files Changed Coverage
nanomq/acl_handler.c 0.00%
nanomq/bridge.c 55.10%
nanomq/rest_api.c 82.05%
nanomq/apps/broker.c 86.20%
nanomq/conf_api.c 100.00%
nanomq/pub_handler.c 100.00%
nanomq/sub_handler.c 100.00%
nanomq/unsub_handler.c 100.00%

📢 Thoughts on this report? Let us know!.

@RanMaoyi
* ADD [quic] Support mqttv5 over quic client
543f866 
Signed-off-by: Moi Ran <maoyi.ran@emqx.io>
JaylinYu
JaylinYu approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@JaylinYu JaylinYu merged commit 8be6240 into jaylin/develop Sep 22, 2023
57 of 82 checks passed
@JaylinYu JaylinYu deleted the moi_quic branch September 22, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaylinYu JaylinYu JaylinYu approved these changes

@xinyi-xs xinyi-xs xinyi-xs approved these changes

@wanghaEMQ wanghaEMQ wanghaEMQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RanMaoyi @JaylinYu @xinyi-xs @wanghaEMQ